-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dataset file handling tests in test_datasets.py::test_file_handling
#280
base: main
Are you sure you want to change the base?
Improve dataset file handling tests in test_datasets.py::test_file_handling
#280
Conversation
I ran the test that fails on windows locally because Appveyor is booked out, and saw this:
|
This commit modifies test_datasets.test_file_handling to be able to test with remote paths that contain directories. There is still a possible improvment: support files with non ".txt" suffix. Those are currently not supported because replace file fails due to "changing file types".
co-authored by @adswa, @bpoldrack Use suggestions by Ben and Adina to improve the code Rebased on main
1e954de
to
fae7605
Compare
…s-with-directories
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 93.78% 93.81% +0.03%
==========================================
Files 17 17
Lines 965 954 -11
==========================================
- Hits 905 895 -10
+ Misses 60 59 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR is a bit dated and seemingly got lost after the development sprint, but I rebased it and all the tests pass, and I can't see anything wrong with it.
…s-with-directories
This PR modifies
test_datasets.py::test_file_handling
to be able to test with remote paths that contain directories.There are still possible improvements: support files with non ".txt" suffix. Those are currently not supported because replace file fails due to "changing file types".