Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make update-mirror.yml trigger builds on new tags #12

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 18, 2020

For #8.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion (could be argued against ;))


- name: Determine new tags
run: |
comm -23 <(git tag | sort) \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool -- didn't know about comm, nice

| sort) > new-tags.txt

- name: Push new objects to mirror
run: git push --tags origin upstream/master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just push upstream/master here but push tags only after uploading the built artifact. This way if build (but not testing) fails, we have a chance to adjust our workflow and cause rebuild of all the "yet to be done" tags. WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yarikoptic So are you expecting the build workflows to only ever be manually/programmatically dispatched using tags, not commit hashes or other refspecs? The build workflows will need to be edited to pull the input tags from the official repository and then push them at the end, something that doesn't apply to general commitishes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, I see... oh well, then let's keep as is to keep it simple(r) for now

@yarikoptic yarikoptic merged commit 9c34450 into master Nov 19, 2020
@yarikoptic yarikoptic deleted the gh-8b branch November 19, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants