Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No create permissions dialog #1934

Merged
merged 16 commits into from
Dec 20, 2024
Merged

No create permissions dialog #1934

merged 16 commits into from
Dec 20, 2024

Conversation

sjorobekov
Copy link
Contributor

@sjorobekov sjorobekov commented Dec 12, 2024 •
edited
Loading

Improve UX, by showing on root page Create Workbook / Collection button, even if user doesn't have permission.
It will open dialog with a prompt that user doesn't have enough permissions.

@sjorobekov sjorobekov changed the title Charts 9786 no create permissions dialog WIP: Charts 9786 no create permissions dialog Dec 12, 2024
@datalens-weblate-robot
Copy link
Contributor

i18n-check

The following components have not been translated

component.dialog-collection-no-create-permission.view (ru)
component.dialog-collection-no-create-permission.view (en)
component.dialog-info.view (ru)
component.dialog-info.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

📦 Statoscope quick diff with main-branch:

⏱ Build time: 2.4 sec (1.27%)

⚖️ Initial size: 0.32 kb (0.01%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

E2E Report is ready.

@sjorobekov sjorobekov changed the title WIP: Charts 9786 no create permissions dialog No create permissions dialog Dec 12, 2024
imsitnikov
imsitnikov previously requested changes Dec 12, 2024
View reviewed changes
src/i18n-keysets/component.dialog-collection-no-create-permission.view/en.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
...llectionsStructure/CollectionNoCreatePermissionDialog/CollectionNoCreatePermissionDialog.tsx Show resolved Hide resolved
src/ui/components/DialogInfo/DialogInfo.tsx Outdated Show resolved Hide resolved
...llectionsStructure/CollectionNoCreatePermissionDialog/CollectionNoCreatePermissionDialog.tsx Outdated Show resolved Hide resolved
src/ui/units/collections/components/CollectionPage/hooks/useLayout.tsx Outdated Show resolved Hide resolved
src/ui/units/collections/components/CollectionPage/hooks/useLayout.tsx Outdated Show resolved Hide resolved
src/ui/units/collections/components/CollectionPage/hooks/useLayout.tsx Outdated Show resolved Hide resolved
src/ui/units/collections/components/CollectionPage/hooks/useLayout.tsx Show resolved Hide resolved
@datalens-weblate-robot
Copy link
Contributor

i18n-check

The following components have not been translated

component.dialog-collection-no-create-permission.view (ru)
component.dialog-collection-no-create-permission.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@datalens-weblate-robot
Copy link
Contributor

i18n-check

The following components have not been translated

component.dialog-collection-no-create-permission.view (ru)
component.dialog-collection-no-create-permission.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@datalens-weblate-robot
Copy link
Contributor

i18n-check

The following components have not been translated

component.dialog-collection-no-create-permission.view (ru)
component.dialog-collection-no-create-permission.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

jhoncool
jhoncool previously approved these changes Dec 18, 2024
View reviewed changes
@datalens-weblate-robot
Copy link
Contributor

i18n-check

The following components have not been translated

component.dialog-collection-no-create-permission.view (ru)
component.dialog-collection-no-create-permission.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@datalens-weblate-robot
Copy link
Contributor

i18n-check

The following components have not been translated

component.dialog-collection-no-create-permission.view (ru)
component.dialog-collection-no-create-permission.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@datalens-weblate-robot datalens-weblate-robot mentioned this pull request Dec 19, 2024
Merged
@datalens-weblate-robot @weblate @dtikhonova
Translations update from Weblate Gravity for PR #1934 (#1960)
218ab11 
Co-authored-by: Weblate <[email protected]>
Co-authored-by: Darya Tikhonova <[email protected]>
Co-authored-by: Matthew Casserly <[email protected]>
@sjorobekov sjorobekov removed the request for review from imsitnikov December 20, 2024 14:41
@sjorobekov sjorobekov dismissed imsitnikov’s stale review December 20, 2024 14:46

Some GitHub issue

@sjorobekov sjorobekov merged commit c482663 into main Dec 20, 2024
9 checks passed
@sjorobekov sjorobekov deleted the CHARTS-9786_no_create_permissions_dialog_2 branch December 20, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoncool jhoncool jhoncool approved these changes

@imsitnikov imsitnikov imsitnikov left review comments

Assignees
No one assigned
Labels
changelog component/navigation type/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sjorobekov @datalens-weblate-robot @jhoncool @imsitnikov