Add entries index by tenant_id and scope #244
Merged
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanenkoxx
force-pushed
the
DLAPI-11-add-entries-tenant-id-scope-index
branch
from
2ca7db0 to
87757a8
Compare
stepanenkoxx
requested review from
sjorobekov,
jhoncool,
imsitnikov and
Sergey-weber
jhoncool
reviewed
Jan 30, 2025
| } | ||
|
|
||
| export async function down(knex: Knex): Promise<void> { | ||
| return knex.raw(`DROP INDEX IF EXISTS entries_tenant_id_scope_idx;`); |
There was a problem hiding this comment.
Let's not use IF EXISTS in the down transaction
There was a problem hiding this comment.
The reason is that it might mask an error?
jhoncool
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.