-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charts 8598 change workbook permission mapping #29
Merged
Sergey-weber
merged 9 commits into
main
from
CHARTS-8598-change-workbook-permission-mapping
Nov 21, 2023
Merged
Charts 8598 change workbook permission mapping #29
Sergey-weber
merged 9 commits into
main
from
CHARTS-8598-change-workbook-permission-mapping
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsitnikov
requested changes
Nov 17, 2023
src/services/new/workbook/utils/get-entry-permissions-by-workbook.ts
Outdated
Show resolved
Hide resolved
imsitnikov
requested changes
Nov 20, 2023
imsitnikov
requested changes
Nov 20, 2023
imsitnikov
approved these changes
Nov 20, 2023
Sergey-weber
deleted the
CHARTS-8598-change-workbook-permission-mapping
branch
November 21, 2023 06:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change behavior for method getEntryPermissionsByWorkbook
Change to syns
added logic set permissions depends on entry scope