Added sorting by aliases in favorites #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoncool
reviewed
Jan 18, 2024
src/db/models/favorite/index.ts
Outdated
| @@ -388,8 +389,10 @@ class Favorite extends Model { | |||
|
|
|||
| const {login} = requestedBy; | |||
|
|
|||
| const alias = name ? name.toLowerCase() : null; | |||
There was a problem hiding this comment.
What happened if someone send name == '' (empty string) to api? Is it okay that alias will be null and displayAlias will be empty string
There was a problem hiding this comment.
It's possible if you make api call manually (from ui it is not possible to send empty string now), anyway l agree that it should be consistent. Fixed
jhoncool
reviewed
Jan 18, 2024
| require('../../index'); | ||
| import {db} from '../index'; | ||
|
|
||
| (async function () { |
There was a problem hiding this comment.
I think we need to write a description here about reason or use cases for that scripts.
There was a problem hiding this comment.
I think it is a temporary script which facilitates migration, and will be deleted after release
There was a problem hiding this comment.
Anyway, added comment with description at top
imsitnikov
previously approved these changes
Jan 18, 2024
imsitnikov
previously approved these changes
Jan 18, 2024
imsitnikov
previously approved these changes
Jan 18, 2024
imsitnikov
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.