Skip to content

Update dependencies #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: upgrade-dependencies
Choose a base branch
from

Conversation

Anastastasia-B
Copy link

@Anastastasia-B Anastastasia-B commented Sep 14, 2023

Updated the dependencies

@Anastastasia-B Anastastasia-B changed the base branch from master to upgrade-dependencies September 14, 2023 13:25
@Anastastasia-B Anastastasia-B force-pushed the update-dependencies branch 5 times, most recently from d7e2bb8 to bb9d760 Compare October 8, 2023 16:42
@Anastastasia-B Anastastasia-B marked this pull request as ready for review October 9, 2023 12:24
@@ -47,7 +47,6 @@ const internalConfig = {
extends: [
'stylelint-config-datarockets',
'stylelint-config-styled-components',
fs.existsSync(pathToPrettier) && 'stylelint-config-prettier',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stylelint 15 deprecated all conflicting rules, so stylelint-config-prettier is no longer nessesary
https://www.npmjs.com/package/stylelint-config-prettier (see note)

Copy link

@lesha1201 lesha1201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to review without diving into details but diving into detail will take too much time which doesn't make much sense in case of a deprecated project.

@@ -15,58 +15,57 @@
"node": ">=12"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"node": ">=12"
"node": ">=16"

@atatarenko
Copy link

@lesha1201 thank you for your feedback. In this case, should we archive this repository or what your recommendation would be?

cc @ezhlobo

@lesha1201
Copy link

@atatarenko

Either rewrite it completely to fit our needs for starting new projects or archive it for now. The first option is quite time-consuming and requires to involve multiple people to discuss all the conventions, stack, etc.

@atatarenko
Copy link

@lesha1201 I got it...well, both options are sort of not fun...but having some action over the repo is surely needed because keeping dreact as-is makes things pretty misleading. Personally, I'm leaning to an option of archiving dreact. We haven't actively contributed nor use it for some quite long period of time.

@atatarenko
Copy link

@Anastastasia-B I hate to say that but it seems like this PR won't be merged because it doesn't make sense to keep it going in the current situation. I see you've done some good job here and hope you made it to gain some good knowledge from this experience which would be beneficial to you anyways.

@atatarenko atatarenko mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants