Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I develop the gem, I'd like to be confident in code I add, so I'd like tests to help me with it #12

Open
AleksSenkou opened this issue Nov 6, 2018 · 5 comments
Assignees
Labels
infra Gem's behavior changes: speed changes, refactoring, tests, README updates

Comments

@AleksSenkou
Copy link
Contributor

Tests for all features in rails views, not cells

@AleksSenkou AleksSenkou added the infra Gem's behavior changes: speed changes, refactoring, tests, README updates label Nov 6, 2018
@DDKatch DDKatch self-assigned this Nov 6, 2018
@DDKatch
Copy link
Contributor

DDKatch commented Nov 8, 2018

@roman-dubrovsky including these helpers breaks tests executing, can we remove them from codebase because in real app we have access to methods from these helpers?

@DDKatch
Copy link
Contributor

DDKatch commented Nov 8, 2018

    include AbstractController::Helpers
    include ActionDispatch::Http::Cache::Request
    include ActionView::RecordIdentifier

@AleksSenkou
Copy link
Contributor Author

We can run 2-4 hours investigation raid here in order to understand whether we need to include those modules:

  1. allocate rails-views' path in gemfile to local gem
  2. change gem locally and restart rails server after it
  3. check do we need to run bundle install here ^ (not sure about gem caching)

Going with that ^ we can check the availability of helper methods without including those modules

@AleksSenkou
Copy link
Contributor Author

@DDKatch let's move a discussion for helper modules inclusion to separate issue. This one is for tests coverage 😉

@DDKatch
Copy link
Contributor

DDKatch commented Nov 9, 2018

@AleksSenkou got it, I'll create separate one for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Gem's behavior changes: speed changes, refactoring, tests, README updates
Projects
None yet
Development

No branches or pull requests

2 participants