Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dates lookup from summary/full #35

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

philip-lee-ons
Copy link
Collaborator

PR merges across some changes from the general tidy up. In light of data now being available in CSV other changes are unlikely to be worth working on.

  • summary and full commands get dates from the PDFs rather than a lookup
  • Unit tests all run and are runnable from the project root directory
  • A few formatting issues fixed
  • Legacy modules removed

Note: proc still needs the dates lookup file, was a bigger change to fix it there as well

Testing:

  • Unit tests run
  • Adhoc checks on output for each command for multiple countries
  • GB full file, 2020-04-05, produced is identical to that produced by the current version of project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant