Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e notebooks #192

Merged
merged 8 commits into from
Nov 13, 2023
Merged

E2e notebooks #192

merged 8 commits into from
Nov 13, 2023

Conversation

SergioRec
Copy link
Contributor

@SergioRec SergioRec commented Oct 26, 2023

Description

Added e2e notebooks for Leeds, Marseille and London (incomplete).
Added toml config files for e2e notebooks.
Restructured notebooks/e2e directory.

Motivation and Context

Example e2e notebooks to run pipeline for regions of interest.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Notebooks were run and outputs produced.

Test configuration details:

  • OS: macOS Ventura
  • Python version: 3.9
  • Java version: openJDK 11.0.2
  • Python management system: pip/conda

Advice for reviewer

To note:

  • Inputs and outputs are stored in GCP.
  • None of the notebooks use the currently in development modules for transport network and metrics. They will need to be added later.
  • London does not include the steps to calculate transport network and metrics as it depends on module development.

Checklist:

  • My code follows the intended structure of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional comments

No need to review in depth.

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f60bccd) 97.81% compared to head (8b4644f) 97.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #192   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          14       14           
  Lines        1188     1188           
=======================================
  Hits         1162     1162           
  Misses         26       26           
Flag Coverage Δ
unittests 97.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SergioRec SergioRec marked this pull request as draft November 6, 2023 09:30
@SergioRec
Copy link
Contributor Author

Draft. Need to add new analyse_network and metrics modules when ready.

@SergioRec SergioRec added x-small and removed small labels Nov 9, 2023
@SergioRec SergioRec marked this pull request as ready for review November 9, 2023 08:58
@r-leyshon r-leyshon merged commit fda1e1b into dev Nov 13, 2023
9 checks passed
@r-leyshon r-leyshon deleted the e2e_notebooks branch November 13, 2023 08:51
@ethan-moss ethan-moss restored the e2e_notebooks branch November 22, 2023 18:11
@ethan-moss ethan-moss deleted the e2e_notebooks branch November 22, 2023 18:12
@ethan-moss ethan-moss restored the e2e_notebooks branch November 22, 2023 18:14
@ethan-moss ethan-moss deleted the e2e_notebooks branch November 22, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants