-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
290 docs overall tp pipeline #292
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #292 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 21 21
Lines 1927 1927
=======================================
Hits 1891 1891
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ethan-moss, I've coughed up a bunch of commits which most were straight forward, apart from commit 7b1874a which like yesterday's PR, is commented as being more opinionated than the others. But like yesterday, happy to be disagreed with, in which case feel free to revert lines that you don't agree to.
A few things to note with this one, but this hopefully does not represent a great deal of work:
- I noticed an unresolved link warning when rendering the site. It was complaining about a link to validate_osm in the api reference. After re-running quartodoc build this went away, but I noticed a very minor typo in the osm tutorial. So that's been plopped at the end of this review too.
- The flowchart diagram is a little blurry when rendered for me, I'll attach what I see here for your consideration, though also noting that it actually looks a bit better in my screengrab than on my screen for some reason. This is probably a compromise between file size and getting a large enough diagram to be accessible. Preferably, I would recommend using a mermaid markdown cell to bring the flowchart into version control, but am unsure if there was a reason why you didn't originally do it that way.
- I didn't understand the left hand side of the flow chart. I wonder if people will get confused that the urban_centre is responsible for the GTFS & OSM cropping, rather than the user-defined BBOX. I felt it might be misconstrued as the population, GTFS and OSM processing occurring in parallel. As the flowchart is useful learning aid, I would recommend simplifying it further still to a linear diagram.
But other this I think the page does a great job of summarising the end to end process.
Description
Fixes #290 - adds a new explanation page covering the end-to-end transport performance pipeline.
Motivation and Context
Add an explanation page demonstrating, at a top-level, how
transport_performance
can be used to analyse transport networks.Type of change
How Has This Been Tested?
New documentation: All additions and changes render as expected locally.
Test configuration details:
Advice for reviewer
This branch is not yet up to date with main (likely to be a merge conflict in
.gitignore
. I'm happy to resolve this once #291 is merged todev
- just let me know.Checklist:
dev
Additional comments
None.