Retroactive event calendar #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foodelevator
requested changes
May 3, 2024
foodelevator
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works, and can display events from weeks in the past and future. But the solution isn't the prettiest. It was a bit tricky to get the relative week numbers the calendar component uses to line up when the events change. The calendar component is now instead fed with events from only one week at the time, and then always displays the current
widgetWeekGroupsinstead of calculating which events to show and not. It might also be perceived as slower when viewing future events as they are no longer reused and instead fetched per week.Feel free to suggest or request changes!