Fix error page #81
Merged
Fix error page #81
+169
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Herkarl rebase |
|
omg du funkar ju inte som dependabot. vad konstigt 🤔 |
shouldn't ruin the server side rendering since use effect is only ran on the client
interesting to note: This check can't be combined with the check just above, that broke the page completely.
foodelevator
force-pushed
the
fix-error-page
branch
from
92a2480 to
ce70f99
Compare
Co-authored-by: Mathias Magnusson <[email protected]>
foodelevator
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the error page, and the back button.
The error page was causing hydration errors, this was due to the error parameter being undefined on first page load while rendering clientside, and then updating when it got an answer from taitan.
The server on the other hand, was waiting for the taitan request to finish before rendering the page, making the page render as the error page from the beginning.
So since the server and client disagreed on the initial render, the page became angry, which we stop by never rendering the error page on the server.
Funnily enough, the back button works better in the production environment than on dev. Just like the rest of bawang >:p