Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subfolders on subpages #91

Merged
merged 3 commits into from
Nov 10, 2024
Merged

Subfolders on subpages #91

merged 3 commits into from
Nov 10, 2024

Conversation

Benjaneb
Copy link
Contributor

@Benjaneb Benjaneb commented Nov 7, 2024

If pages are put in subfolders they appear as so:
image

@Benjaneb Benjaneb requested a review from Herkarl November 7, 2024 20:31
{item.title}
</Link>
{item.nav
? <h3>{item.title}</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be opinionated, but are you sure you don't want to link to the subpage for the title item? Since the page will exist and could contain content

Copy link
Contributor Author

@Benjaneb Benjaneb Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure. The only plans we have for this currently are for the committees page, dividing into organs, and we don't have anything to say about each organ. We just want the committee pages to be divided under headings.

Copy link
Member

@Herkarl Herkarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good imo and seems to work locally for me. Left a small comment.

I would perhaps add some margin after the last item in the list to help disambiguate when the subpage list is not last in the sidebar (like in the example). But that is opinionated i suppose.

Might be worth thinking about how to make this look nice when you have a subfolder without the expand=true flag set in meta.toml for the subfolder. In this case it will look like a normal link, but will expand to header with a list below it when you click on it. (since it then will have a nested nav). It looks a bit wonky and inconsistent, but I suppose it is not a planned use-case for now.

@Benjaneb
Copy link
Contributor Author

Benjaneb commented Nov 8, 2024

I would perhaps add some margin after the last item in the list to help disambiguate when the subpage list is not last in the sidebar (like in the example). But that is opinionated i suppose.

This is probably a good idea. I'll fix that before merging.

@Benjaneb Benjaneb merged commit 238df3f into master Nov 10, 2024
1 check passed
@Benjaneb Benjaneb deleted the subfolders-on-subpages branch November 10, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants