-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subfolders on subpages #91
Conversation
{item.title} | ||
</Link> | ||
{item.nav | ||
? <h3>{item.title}</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be opinionated, but are you sure you don't want to link to the subpage for the title item? Since the page will exist and could contain content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure. The only plans we have for this currently are for the committees page, dividing into organs, and we don't have anything to say about each organ. We just want the committee pages to be divided under headings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good imo and seems to work locally for me. Left a small comment.
I would perhaps add some margin after the last item in the list to help disambiguate when the subpage list is not last in the sidebar (like in the example). But that is opinionated i suppose.
Might be worth thinking about how to make this look nice when you have a subfolder without the expand=true
flag set in meta.toml
for the subfolder. In this case it will look like a normal link, but will expand to header with a list below it when you click on it. (since it then will have a nested nav
). It looks a bit wonky and inconsistent, but I suppose it is not a planned use-case for now.
This is probably a good idea. I'll fix that before merging. |
If pages are put in subfolders they appear as so:
![image](https://private-user-images.githubusercontent.com/71073919/384128845-a3db4cc7-4c69-492a-95d2-66111dc8f02f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMTcwMzcsIm5iZiI6MTczOTAxNjczNywicGF0aCI6Ii83MTA3MzkxOS8zODQxMjg4NDUtYTNkYjRjYzctNGM2OS00OTJhLTk1ZDItNjYxMTFkYzhmMDJmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDEyMTIxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZkZTY5YWRmYjk1YmE0MDhmMTMxOWNmMmFhMjI0OWE3N2MzNzg1MGE0NGM3M2ZkNzk5ODc4ZGYxOTY4NDc3YjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4HJdzfDfgWYis3KY6w3DpjvSQu3zKZ9Iba2nMDfi2MI)