Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: link in stay light on active #32

Merged
merged 2 commits into from
Oct 3, 2024
Merged

feat: link in stay light on active #32

merged 2 commits into from
Oct 3, 2024

Conversation

WALLE-AXIOM
Copy link
Contributor

@WALLE-AXIOM WALLE-AXIOM requested a review from Benjaneb October 3, 2024 20:22
Benjaneb
Benjaneb approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@Benjaneb Benjaneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WALLE-AXIOM WALLE-AXIOM merged commit 47aefbb into master Oct 3, 2024
2 checks passed
@WALLE-AXIOM WALLE-AXIOM deleted the navbar-current branch October 3, 2024 20:40
@foodelevator
Copy link
Member

It would be nice if for example the "Nämnder" button would still be active if you're on e.g. /namnder/informationsorganet

@Benjaneb Benjaneb mentioned this pull request Oct 9, 2024
Open
foodelevator added a commit that referenced this pull request Oct 19, 2024
@foodelevator
Revert "feat: link in stay light on active (#32)"
2774e1c 
This reverts commit 47aefbb.
@foodelevator foodelevator restored the navbar-current branch October 19, 2024 23:02
@foodelevator foodelevator deleted the navbar-current branch October 19, 2024 23:03
@foodelevator
Copy link
Member

This, or more specifically:

/app/node_modules/methone/dist/components/TopBar.js:183
  className: window.location.pathname === link.props.to && "current",
             ^

ReferenceError: window is not defined

made bawang crash on start when dependabot updated express (not sure why it happened now).

Methone is also server-rendered, which is why window doesn't always exist. Not sure how to solve this in a nice way.

@foodelevator
Copy link
Member

@Benjaneb @WALLE-AXIOM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjaneb Benjaneb Benjaneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the link in the navbar stay light cerise on the active page
3 participants
@WALLE-AXIOM @foodelevator @Benjaneb