Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.5.0 #185

Merged
merged 94 commits into from
Feb 21, 2024
Merged

Release/1.5.0 #185

merged 94 commits into from
Feb 21, 2024

Conversation

hhund
Copy link
Member

@hhund hhund commented Feb 21, 2024

closes #183
closes #178
closes #175
closes #170
closes #169
closes #165
closes #164
closes #160
closes #158
closes #152

hhund and others added 30 commits December 18, 2023 21:32
issues/158_Start_New_Development_Cycle
'origin/issues/158_Start_New_Development_Cycle' into develop
Fix missed check 'privateKeyPath' is readable in FhirClientConfig
'origin/issue/165_activitydefinition_url_below_modifier' into develop
* Orphaned entries in the read_access table are deleted via a db
migration step.
* New BEFORE DELETE database triggers are added to all resource tables
except tasks and questionnaire_reponses as access to theses resources is
not granted via read_access entries. The delete triggers are used to
remove corresponding entries from the read_access table that are no
longer needed when a resources is permanently deleted.
* now using thymeleaf template engine to generate html
* adds new UIs for some resources and search-sets
* adds copy button for Task and QuestionnaireReponse html Input fields
* adds insert placeholder button for boolean input fields
* adds support for empty QuestionnaireReponse items and Task inputs
using the FHIR data absent reason extension
https://hl7.org/fhir/R4/extension-data-absent-reason.html
* switching between html, json and xml views now pushes browser history
entries
* adds shortcuts (h, j, x) to switch between html, json and xml views.
Shortcuts need to be used with browser specific modifier keys, see
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey
hhund and others added 26 commits February 19, 2024 20:59
* Removed the default mod.css file from the jar internal static folder.
* Generated fhir/bpe html now only links to the mod.css if the file
exists in the ui folder of the docker container.
'origin/issue/175_Template_Engine_for_HTML_UIs' into develop
issue/175_Template_Engine_for_HTML_UIs
…om:datasharingframework/dsf.git into issue/175_Template_Engine_for_HTML_UIs
'origin/issue/175_Template_Engine_for_HTML_UIs' into develop
@hhund hhund added this to the 1.5.0 milestone Feb 21, 2024
@hhund hhund self-assigned this Feb 21, 2024
String fhirType = typedValue.getClass().getAnnotation(DatatypeDef.class).name();

// TODO use switch expression with pattern matching after switching to java 21
if (typedValue instanceof BooleanType b)

Check notice

Code scanning / CodeQL

Chain of 'instanceof' tests Note

This if block performs a chain of 10 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.
Copy link
Member Author

@hhund hhund Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When upgrading to Java 21, we should use switch type pattern matching here.

private String getStringValue(Type typedValue)
{
// TODO use switch expression with pattern matching after switching to java 21
if (typedValue instanceof DecimalType d)

Check notice

Code scanning / CodeQL

Chain of 'instanceof' tests Note

This if block performs a chain of 8 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.
Copy link
Member Author

@hhund hhund Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When upgrading to Java 21, we should use switch type pattern matching here.

private String getHtmlInputType(Type typedValue)
{
// TODO use switch expression with pattern matching after switching to java 21
if (typedValue instanceof BooleanType)

Check notice

Code scanning / CodeQL

Chain of 'instanceof' tests Note

This if block performs a chain of 11 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.
Copy link
Member Author

@hhund hhund Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When upgrading to Java 21, we should use switch type pattern matching here.

@hhund hhund merged commit 12ddd12 into main Feb 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment