Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to pass in pre-computed signatures #6

Merged
merged 8 commits into from
Oct 17, 2023

Conversation

rchan26
Copy link
Collaborator

@rchan26 rchan26 commented Oct 11, 2023

  • Allow passing on pre-computed signatures into SignatureMahalanobisKNN rather than having to compute them
    • Signatures are only computed if X is provided and signatures is not in the .fit() method (similarly for conformance)
  • Added docstrings for Add docstrings to all classes and methods #1 (change to numpy docstring format)
  • Added type hints for Add type hints #2

@sz85512678
Copy link
Collaborator

Good work Ryan, thank you! Minor concerns about coding styles, let me know if you think what I said make sense... maybe not as it's late on Friday!

@rchan26
Copy link
Collaborator Author

rchan26 commented Oct 17, 2023

Latest changes:

  • Made the the error messages for not passing X or signatures or for not fitting the model yet global variables so you can update the error messages in one place (no duplication)
  • Added back the documentation for sktime SignatureTransformer arguments and info for what we set as default arguments
  • Moved the compute_auc methods in SignatureMahalanobisKNN to standalone functions outside the class in utils.py

@sz85512678
Copy link
Collaborator

Thanks Ryan for the changes :).

@sz85512678 sz85512678 merged commit cd40ac2 into main Oct 17, 2023
15 checks passed
@rchan26 rchan26 deleted the pre-comp-signature-passing branch October 17, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants