Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cassandra native protocol library version #124

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Update Cassandra native protocol library version #124

merged 1 commit into from
Jun 20, 2024

Conversation

lukasz-antoniak
Copy link
Collaborator

@lukasz-antoniak lukasz-antoniak commented Jun 17, 2024 •
edited
Loading

Issue link: #116

@lukasz-antoniak lukasz-antoniak marked this pull request as ready for review June 17, 2024 15:45
@joao-r-reis joao-r-reis changed the title Update Cassandra native protocol version Update Cassandra native protocol library version Jun 19, 2024
@joao-r-reis
Copy link
Collaborator

joao-r-reis commented Jun 19, 2024 •
edited
Loading

Quick tip, if you put:

fix #116

in the PR description it will automatically link the issue and close it when the PR is merged. I'll link it manually

@joao-r-reis joao-r-reis linked an issue Jun 19, 2024 that may be closed by this pull request
Update go-cassandra-native-protocol dependency #116
Closed
joao-r-reis
joao-r-reis reviewed Jun 19, 2024
View reviewed changes
go.mod Show resolved Hide resolved
joao-r-reis
joao-r-reis reviewed Jun 19, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
joao-r-reis
joao-r-reis reviewed Jun 19, 2024
View reviewed changes
proxy/codecs.go Outdated Show resolved Hide resolved
joao-r-reis
joao-r-reis reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@joao-r-reis joao-r-reis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left some comments.

@lukasz-antoniak
Copy link
Collaborator Author

lukasz-antoniak commented Jun 19, 2024 •
edited
Loading

Thank you, good catches. Applied all fixes. Please review again when you have time. If it is OK, I will squash commits and merge.

joao-r-reis
joao-r-reis approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@joao-r-reis joao-r-reis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Did you run a quick manual test against an Astra database?

@lukasz-antoniak
Copy link
Collaborator Author

Yes, I tested with Astra manually.

@lukasz-antoniak lukasz-antoniak merged commit b366cb0 into main Jun 20, 2024
2 checks passed
@lukasz-antoniak lukasz-antoniak deleted the 116 branch June 20, 2024 11:12
@joao-r-reis joao-r-reis mentioned this pull request Jul 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joao-r-reis joao-r-reis joao-r-reis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update go-cassandra-native-protocol dependency
2 participants
@lukasz-antoniak @joao-r-reis