Emit Download and Append events #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bltavares
approved these changes
May 21, 2020
This removes the generic argument from the Feed struct, making it simpler to work with. Instead, the Storage is internally put into a Box<dyn DynStorage>, where DynStorage is an async trait with the public Storage functions.
... so that addding new events is not a breaking change.
Without this, some examples fail. Not sure exactly why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose one: a 🙋 feature
This PR adds a
subscribemethod to the Feed which returns aReceiver<Event>. Currently, there's two events being emitted:DownloadandAppend. More can be added over time/when needed.I think this will be important for upcoming replication integration.
Checklist
Context
Semver Changes
minor as it's only an API addition I think