example to ensure structs are send #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
yoshuawuyts
reviewed
Feb 17, 2020
Cargo.toml
Outdated
| @@ -25,7 +25,7 @@ failure = "0.1.5" | |||
| flat-tree = "4.1.0" | |||
| lazy_static = "1.3.0" | |||
| memory-pager = "0.9.0" | |||
| merkle-tree-stream = "0.10.0" | |||
| merkle-tree-stream = { version = "0.10.0", git = "https://github.com/bltavares/merkle-tree-stream", branch = "send" } | |||
There was a problem hiding this comment.
I believe we've merged this, but not published. Added you as a contrib, let me know if you need publish access on crates.io as well!
yoshuawuyts
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose one: a 🙋 feature
Using hypercore on a multi-threaded async/await executor requires it to be send. This commit adds an example which requires the crate to be send, and changes all references to Rc with Arc.
Checklist
asyncexampleContext
Working on making hypercore thread-safe to use with async i/o. Draft PR to work in a distribute fashion with others and have earlier feedback.
Related to:
Needs:
Semver Changes
Minor?