src/message_iter: Maintain reference to underlying DBusMessage #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weirdly, an DBusMessageIter doesn't increase the refcount of the referred DBusMessage, thus we need to maintain the reference manually to prevent underlying DBusMessage from garbage collection before the DBusMessageIter is collected, which results in a dangling reference. Let's introduce a new type, lDBusMessageIter, which contains both the iterator and the underlying DBusMessage, and refer/unref the message during creation, initialization and garbage collection of the iterator. Closes: daurnimator#20 Signed-off-by: Yao Zi <[email protected]>
|
@daurnimator Thanks for your review (and the suggestion for the solution)! btw, is it possible to add some testing infra for ldbus to make it more robust? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weirdly, an DBusMessageIter doesn't increase the refcount of the referred DBusMessage, thus we need to maintain the reference manually to prevent underlying DBusMessage from garbage collection before the DBusMessageIter is collected, which results in a dangling reference.
Let's introduce a new type, lDBusMessageIter, which contains both the iterator and the underlying DBusMessage, and refer/unref the message during creation, initialization and garbage collection of the iterator.
Closes: #20