Skip to content

Commit

Permalink
don't explicitly tag base:latest or cc:latest in cloudbuild.yaml (Goo…
Browse files Browse the repository at this point in the history
…gleContainerTools#287)

* don't explicitly latest base:latest or cc:latest in cloudbuild.yaml

* remove tagging static as latest as well

* add comment on why base, cc, and static are missing from cloudbuild.yaml

* remove static:latest from images list
  • Loading branch information
sharifelgamal authored Jan 31, 2019
1 parent eba381a commit 55b0eb2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 15 deletions.
3 changes: 0 additions & 3 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@ load("@io_bazel_rules_docker//container:container.bzl", "container_bundle")
container_bundle(
name = "all",
images = {
"gcr.io/{PROJECT_ID}/go:latest": "//base:static",
"gcr.io/{PROJECT_ID}/base:latest": "//base:base",
"gcr.io/{PROJECT_ID}/base:debug": "//base:debug",
"gcr.io/{PROJECT_ID}/cc:latest": "//cc",
"gcr.io/{PROJECT_ID}/cc:debug": "//cc:debug",
"gcr.io/{PROJECT_ID}/java:latest": "//java:java8",
"gcr.io/{PROJECT_ID}/java:8": "//java:java8",
Expand Down
17 changes: 5 additions & 12 deletions cloudbuild.yaml
Original file line number Diff line number Diff line change
@@ -1,24 +1,20 @@
timeout: 1800s
steps:
steps:

# Publishing base, cc, and static as latest is handled in a separate release process
- name: gcr.io/cloud-builders/bazel
args: ['run', '//base:static']
- name: gcr.io/cloud-builders/docker
args: ['tag', 'bazel/base:static', 'gcr.io/$PROJECT_ID/static:latest']

- name: gcr.io/cloud-builders/bazel
args: ['run', '//base:base']
- name: gcr.io/cloud-builders/docker
args: ['tag', 'bazel/base:base', 'gcr.io/$PROJECT_ID/base:latest']


- name: gcr.io/cloud-builders/bazel
args: ['run', '//base:debug']
- name: gcr.io/cloud-builders/docker
args: ['tag', 'bazel/base:debug', 'gcr.io/$PROJECT_ID/base:debug']

- name: gcr.io/cloud-builders/bazel
args: ['run', '//cc']
- name: gcr.io/cloud-builders/docker
args: ['tag', 'bazel/cc:cc', 'gcr.io/$PROJECT_ID/cc:latest']

- name: gcr.io/cloud-builders/bazel
args: ['run', '//cc:debug']
Expand Down Expand Up @@ -91,7 +87,7 @@ steps:
- name: gcr.io/cloud-builders/bazel
args: ['run', '//experimental/nodejs:debug']
- name: gcr.io/cloud-builders/docker
args: ['tag', 'bazel/experimental/nodejs:debug', 'gcr.io/$PROJECT_ID/nodejs:debug']
args: ['tag', 'bazel/experimental/nodejs:debug', 'gcr.io/$PROJECT_ID/nodejs:debug']

- name: gcr.io/cloud-builders/bazel
args: ['run', '//experimental/dotnet']
Expand All @@ -105,10 +101,7 @@ steps:


images:
- 'gcr.io/$PROJECT_ID/static:latest'
- 'gcr.io/$PROJECT_ID/base:latest'
- 'gcr.io/$PROJECT_ID/base:debug'
- 'gcr.io/$PROJECT_ID/cc:latest'
- 'gcr.io/$PROJECT_ID/cc:debug'
- 'gcr.io/$PROJECT_ID/java:latest'
- 'gcr.io/$PROJECT_ID/java:8'
Expand Down

0 comments on commit 55b0eb2

Please sign in to comment.