Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom validation #8

Closed
2 of 3 tasks
davelopez opened this issue Jan 31, 2022 · 2 comments
Closed
2 of 3 tasks

Custom validation #8

davelopez opened this issue Jan 31, 2022 · 2 comments
Assignees

Comments

@davelopez
Copy link
Owner

davelopez commented Jan 31, 2022

In addition to syntax validation, the extension could:

@davelopez
Copy link
Owner Author

davelopez commented Apr 4, 2022

These custom validations will be additional contributions to the schema validation added in #18.

The release entry has been already added as required property to the schema here. Workflows missing this release property will show an error level entry in the Problems panel:
Screenshot from 2022-04-04 12-07-55
If we want to show a warning level entry instead we will need to remove it from the required properties in the schema and add it to the custom validation contributions.

Update

We decided to keep the schema validation rules as the minimum requirements for all workflows and then define different Profiles containing additional custom sets of rules with different severity levels. And then, let the user choose which profile to use (see #27).

@davelopez
Copy link
Owner Author

Custom validation rules #35 and profiles #46 are now supported. The complete list of custom validation rules will be tracked in #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant