Add support for custom validators #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the NativeWorkflowDocument based on JSONDocument.
Implementing a collection of `ValidationContributor`s and adding them to the language service through `setValidationContributors` will allow to define custom validation rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the groundwork for #8 and #27
A
WorkflowLanguageServicecan now get a list ofValidationContributors which contribute new diagnostics based on custom rules.The MissingPropertyValidationRule is an example of this kind of
ValidationContributor. i.e. we can then make thereleaseproperty required by adding the rule like:The next step will be defining more custom rules (#8) and grouping them under
Profilesso we can add a setting option to address #27