adding support for object method components #27
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesnx
reviewed
Aug 5, 2025
Comment on lines
+198
to
+211
| let obj = | ||
| object | ||
| method make () ~children = JSX.node "div" [] [ JSX.string children ] | ||
| end | ||
|
|
||
| (* The point of this test is to verify that -- | ||
| * assuming our jsx provider has properly output the object component | ||
| * we can process it -- this avoids having to add any mlx files to our test | ||
| * or having to extend ReasonML *) | ||
| let object_children = | ||
| test "object_children" @@ fun () -> | ||
| let str = (obj#make () ~children:"test" [@JSX]) in | ||
| assert_string (JSX.render str) "<div>test</div>" | ||
|
|
There was a problem hiding this comment.
This test doesn't reflect much from the change on the ppx. I mean, the current test case is valid without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for experimental object-method components as proposed here
These would look like this:
<obj#meth/>or
<obj#meth>children</obj#meth>The rationale for enabling this pattern is in the linked PR for MLX.
Probably should not be merged until the MLX PR is merged and the syntax is finalized.