-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserving this
identity (Vue 3) + tweaks
#32
base: feature/vue-3
Are you sure you want to change the base?
Preserving this
identity (Vue 3) + tweaks
#32
Conversation
BTW - sorry to let this go off the boil. Work has been particularly intense this last 6 weeks. I'm hoping to get some time on OSS again this week. |
No worries! It hasn't been blocking so far, the work on our project is still isolated to one experimental branch, so |
Updating the docs has taken a bit longer than expected, so this branch should be ready tomorrow |
So I think I can make VueStore in vue 3 work
The one concession it requires is that it doesn't support "dynamic" watches or computed properties, because it the vue store will be injected "at some point" in he hierarchy, it'll only be able to (reliably) scan the prototype, not any values added at runtime. |
So doing it that way would be a breaking change, however I can make it fall back to the old behavior when used as a decorator, then discourage using that method in the documentation |
This implements #29, #30, and #31. I'll update this branch as those issues are discussed