no milestone means the empty milestone

david-mcmahon · May 29, 2016 · 8f3b7bb · 8f3b7bb
1 parent e3d0377
commit 8f3b7bb
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/mungegithub/mungers/submit-queue.go b/mungegithub/mungers/submit-queue.go
@@ -753,8 +753,12 @@ func (sq *SubmitQueue) validForMerge(obj *github.MungeObject) bool {
 		return false
 	}
 
-	if milestone := obj.Issue.Milestone; milestone != nil && milestone.Title != nil {
-		title := *milestone.Title
+	if milestone := obj.Issue.Milestone; true {
+		title := ""
+		// Net set means the empty milestone, ""
+		if milestone != nil && milestone.Title != nil {
+			title = *milestone.Title
+		}
 		for _, blocked := range sq.doNotMergeMilestones {
 			if title == blocked {
 				sq.SetMergeStatus(obj, unmergeableMilestone)