Improve the design and the insolation of the tab bar and add the Add option #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the design of the tab bar is a float tab bar of white color, instead of a tab bar gray anchored at the bottom of the page. Also, now, when a tab is selected in the tab bar, this tab shows a border of the color blue in its bottom, instead of changing its background color to the red color.
The method used to isolate the tab bar using the "all" property was changed to use an iframe. For more details on this decision, see the issue #6.
When the user clicks in the Add option, a new tab is added to the tab bar. Fixes: - Now only a tab can be selected at a time, before, all tabs that were added or clicked were selected. Now only the new tab or the clicked tab is selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the method of insolation
The method used to insolate the tab bar was changed. Now we use iframe instead of the "all" property. For more details about this decision see the issue #6.
Improve the design of the tab bar
The design of the tab bar was improved:
Old
New
See the commit 31a239d for more details.
Add option
Add the Add option. This option lets the user add new tabs to the tab bar.
QA
npm run build