Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update leafcutter_cluster_regtools.py #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boxiangliu
Copy link

Changed line 392: refine_cluster() -> if (count/float(totN) >= cutoff and count >= readcutoff): to if (count/float(totN) >= cutoff and totN >= readcutoff):

Changed line 392: `refine_cluster()` -> `if (count/float(totN) >= cutoff and count >= readcutoff):` to `if (count/float(totN) >= cutoff and totN >= readcutoff):`
@TimD1
Copy link

TimD1 commented Jan 7, 2025

Seconding this issue, @davidaknowles .

As is, leafcutter filters each junction if the per-junction read count is less than --minclureads instead of filtering each cluster if the total number of reads supporting all junctions in a cluster are less than --minclureads.

Based on the command-line help info, this is not the intended behavior.

-m MINCLUREADS, --minclureads=MINCLUREADS
                        minimum reads in a cluster (default 30 reads)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants