Skip to content

Commit

Permalink
Remove stray print statements in BroadcastStyle
Browse files Browse the repository at this point in the history
  • Loading branch information
@davidavdav
davidavdav committed Sep 27, 2018
1 parent 162aa3d commit 8ab1e80
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions src/keepnames.jl
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## index.jl methods for NamedArray that keep the names (some checking may be done)
## keepnames.jl methods for NamedArray that keep the names (some checking may be done)

## (c) 2013, 2014, 2017 David A. van Leeuwen
## (c) 2013, 2014, 2017, 2018 David A. van Leeuwen

## This code is licensed under the MIT license
## See the file LICENSE.md in this distribution
Expand Down Expand Up @@ -52,10 +52,8 @@ end
Base.BroadcastStyle(::Type{A}) where {A <: NamedArray} = Broadcast.ArrayStyle{A}()
function Base.similar(bc::Broadcast.Broadcasted{Broadcast.ArrayStyle{A}},
::Type{T}) where {A <: NamedArray, T}
println("....................")

This comment has been minimized.

Sign in to view

Copy link
@diegozea

diegozea Oct 17, 2018

Contributor

@davidavdav Can we create a minor tag to include this change into METADATA?

This comment has been minimized.

Sign in to view

Copy link
@diegozea

diegozea Oct 19, 2018 •
edited
Loading

Contributor

It isn't nice to have those prints in the stable version:

image
namedarray = find_namedarray(bc)
println(namedarray)
similar(namedarray, T)
return similar(namedarray, T)
end
"`find_namedarray(As)` returns the first NamedArray among the arguments."
find_namedarray(bc::Base.Broadcast.Broadcasted) = find_namedarray(bc.args)
Expand Down

2 comments on commit 8ab1e80

@davidavdav
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK if you can give me the exact instructions that I need to do in order to publish a new minor version, please.

@diegozea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Thanks :)

I think you already have AttoBot activated in that repo. In that case, you only need to go to the releases page of the repo, Draft a new release with the tag v0.9.2 and then click Publish release: https://github.com/davidavdav/NamedArrays.jl/releases

Please sign in to comment.