Support 1d filter!(), fixes #105

davidavdav · May 24, 2021 · 938a4a9 · 938a4a9
1 parent 64b4b79
commit 938a4a9
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/src/rearrange.jl b/src/rearrange.jl
@@ -122,3 +122,18 @@ function _sortslices(A::NamedArray, d::Val{dims}; kws...) where dims
         B
     end
 end
+
+function Base.filter!(f, n::NamedVector)
+    j = firstindex(n)
+    for (name, i) in n.dicts[1]
+        if f(n.array[i])
+            n.array[j] = n.array[i]
+            n.dicts[1][name] = j
+            j += 1
+        else
+            delete!(n.dicts[1], name)
+        end
+    end
+    deleteat!(n.array, j:length(n.array))
+    return n
+end
diff --git a/test/bugs.jl b/test/bugs.jl
@@ -16,3 +16,10 @@ n = NamedArray([1 2; 3 4], ([11,12], [13,14]))
 s = sum(n, dims=1)
 table = n ./ s 
 @test namesanddim(table) == namesanddim(n)
+
+#105
+a = [10, 20, 30]
+n = NamedArray(a)
+filter!(x -> x > 15, n)
+@test n == a == [20, 30]
+@test names(n, 1) == ["2", "3"]
diff --git a/test/bugs/#105.jl b/test/bugs/#105.jl
@@ -0,0 +1,5 @@
+using NamedArrays
+
+a = [10, 20, 30]
+n = NamedArray(a)
+filter!(x -> x > 15, n)