Add cancel and complete #129
Conversation
|
@davidfowl I just realised that, this PR also contains the modifications of #124. Do you want me separate it from that one? Other: |
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Update="Nerdbank.GitVersioning" Version="3.4.244" /> |
There was a problem hiding this comment.
It is in the master too. I just updated it.
Line 2 in f69fa1b
BedrockFramework/Directory.Build.props
Line 14 in f69fa1b
| @@ -54,7 +54,7 @@ public bool TryParseMessage(in ReadOnlySequence<byte> input, ref SequencePositio | |||
| goto case State.Headers; | |||
|
|
|||
| case State.Headers: | |||
| while (sequenceReader.TryReadTo(out var headerLine, NewLine)) | |||
| while (sequenceReader.TryReadTo(out ReadOnlySequence<byte> headerLine, NewLine)) | |||
There was a problem hiding this comment.
On .NET 6 you get the following error when you use the var:
Error CS0121 The call is ambiguous between the following methods or properties:
'SequenceReader<T>.TryReadTo(out ReadOnlySequence<T>, ReadOnlySpan<T>, bool)' and
'SequenceReader<T>.TryReadTo(out ReadOnlySpan<T>, ReadOnlySpan<T>, bool)'
| @@ -59,7 +59,7 @@ public bool TryParseMessage(in ReadOnlySequence<byte> input, ref SequencePositio | |||
| goto case State.Headers; | |||
|
|
|||
| case State.Headers: | |||
| while (sequenceReader.TryReadTo(out var headerLine, NewLine)) | |||
| while (sequenceReader.TryReadTo(out ReadOnlySequence<byte> headerLine, NewLine)) | |||
There was a problem hiding this comment.
On .NET 6 you get the following error when you use the var:
Error CS0121 The call is ambiguous between the following methods or properties:
'SequenceReader<T>.TryReadTo(out ReadOnlySequence<T>, ReadOnlySpan<T>, bool)' and
'SequenceReader<T>.TryReadTo(out ReadOnlySpan<T>, ReadOnlySpan<T>, bool)'
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Update="Nerdbank.GitVersioning" Version="3.4.244" /> |
There was a problem hiding this comment.
It is in the master too. I just updated it.
Line 2 in f69fa1b
BedrockFramework/Directory.Build.props
Line 14 in f69fa1b
Add CompleteAsync and CancelPending to the Protocols.