Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framing - Variable Size Length Fielded Protocol #143

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

adamradocz
Copy link
Contributor

Fixes #132

Added a framing protocol for a scenario when a frame is variable sized and the header's PayloadLength field is used to split the incoming stream. Plus implemented a sample client and server for this protocol.

Clean and conflict free version of #133

@adamradocz adamradocz changed the title Add Variable Size Length Fielded Protocol Framing - Variable Size Length Fielded Protocol Feb 11, 2022
@davidfowl
Copy link
Owner

@adamradocz Have you been using bedrock? I'd love to hear how, these PRs are great. I'm going to find some time to go through them.

@adamradocz
Copy link
Contributor Author

adamradocz commented Apr 30, 2022

Thanks! Yes, I've been using Bedrock since January, and it's awesome. Mostly using this (Variable Size Length Fielded) protocol over TCP. Probably, I would use it over UDP as well, but I have no idea how to implement the server, so I'm hoping that somebody implements the QUIC protocol and so the UDP with that. :)

@adamradocz
Copy link
Contributor Author

I've been thinking about whether the Header should be struct or class. It would be nice if it wasn't allocated memory either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Framing - Variable size length fielded protocol
2 participants