Collectives section: fix inconsistency in calling preconditions #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isubsmith @maawad @BKP - do you approve this wording change for v1.6 RC2? |
|
These statements read as equivalent to me (which is a good thing). I actually have a slight preference for any since it suggests thinking about the state where the local PE has not called the collective routine yet. However, they're equivalent statement and I'm happy with the change if folks feel that it's clearer. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
See jdinan#25 for more details on the origin of this proposed change. The intent is to clarify that applications do not need to synchronize to ensure that the source array is ready across all PEs prior to calling these collectives.
Proposal Checklist