Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for ES2015 #5

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mediba-Kitada
Copy link

@mediba-Kitada mediba-Kitada commented Mar 30, 2017

  • ES2015 style
  • Lint by ESLint
  • Remove new lines

@davidtheclark
Copy link
Owner

@mediba-Kitada I don't want to do this ... why are you doing this?

@mediba-Kitada
Copy link
Author

@davidtheclark
Thank you for your reply.
I'm using saddler for my app's CI, but output(checkstyle v4.3) with this script doesn't conform checkstyle.
It's because this script outputs XML including new lines and spaces.

checkstyle format is very useful and this script is awesome 😄
So I wanna contributing for your script.

Regards,

@davidtheclark
Copy link
Owner

@mediba-Kitada: Thanks for the explanation! In the future I suggest sharing the explanation, probably by filing an issue, before putting in all the work for a PR, in case the maintainer disagrees with your proposals. 👍

I'm actually wondering now if you're interested in taking over the project? (Then you can use whatever code style you want 😄.) I'm not using checkstyle myself anymore; so this project would be better off in the hands of somebody actively using it. Are you interested? If so, I could add you as a collaborator on npm and transfer the repo to your GitHub account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants