[Discover] Refactor Discover initialization flow #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davismcphee
force-pushed
the
discover-state-refactor
branch
from
a8ff8a4 to
14becb8
Compare
davismcphee
changed the title
## Summary ES|QL doesnt have sometimes the ability to compare a numeric field with a string when this string is a numeric value. For example: ``` FROM kibana_sample_data_logs | WHERE bytes > "6193" ``` This is going to fail, the value should be numeric to work as expected. For this reason controls that have numeric values do not work correctly. This PR is fixing this
## Summary Add alert details action button !! if you have opened up the flyout, reason action button gets hidden. Also fixed dark theme issues for the chart !! <img width="1728" alt="image" src="https://github.com/user-attachments/assets/e9ba3330-2378-418a-91b7-52b67fdc4c09" />
…sing cluster privileges (elastic#212405) ## Summary ### * Fixes Bug: User with no cluster privileges should not be able to enable the risk score When users with no cluster privileges open the risk score page, they don't see any errors and are able to click the install button. This happened because we were only checking for index privileges in the UI, but for the enablement flow we also need to check cluster privileges. I also introduced a new parameter to the missing privileges hook so pages that only need to check for `read` privileges can work as before. https://github.com/user-attachments/assets/fe162005-ee2b-497d-8744-6262e4511d2d * Fixed Bug: The install button was enabled when all toggles were disabled There were too many booleans in the panel, which was confusing and led me to introduce more bugs while trying to fix this one, so I refactored the code to understand it before fixing it. I also simplified the logic to display the modal. Now, it only shows when one of the engines' status is "not_installed" <img width="300" src="https://github.com/user-attachments/assets/a2e8fbba-ac64-4c97-9ef0-ef6fe61e60cd" /> ### To Reproduce 1. Create a user with security privileges and index privileges but no cluster privileges 2. Go to the risk score page and enable the toggle ### Checklist Check the PR satisfies following conditions. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or
## Summary Adds a smoke test for `GET /integrations` endpoint. Handles - elastic/security-team#11232
elastic#212097) ## Summary Adding a UI test plan for Rules, Alerts, Overview page, and Cases
…lastic#213327) The component was replace by an enablement dialog ## Summary Delete the obsolete "enable risk score redirect" test. The redirect button was replaced by an enablement dialog.
…otation layer (elastic#213090) ## Summary Fixes elastic#212917 The root problem is belongs into the annotation layer logic to produce the reference id for the persisted saved object. In the previous logic a new `uuid` was generated all the time leading to a continuous flow of `setState` calls to update the "runtime" state of the Lens object when inline editing: the fix was to produce a stable id in the `extractReferences` logic to avoid the re-renders. The logic has been tweaked a bit now with some extra explanations inline to make it more understandable. New tests have been added to smoke test this scenario. ### Checklist Check the PR satisfies following conditions. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Nick Partridge <[email protected]>
…elastic#212853) (elastic#213329) # Backport This will backport the following commits from `8.18` to `main`: - [[SecuritySolution] Fix risk engine component template renaming (elastic#212853)](elastic#212853) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Pablo Machado","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-03-05T09:50:31Z","message":"[SecuritySolution] Fix risk engine component template renaming (elastic#212853)\n\n## Summary\n\nThe previous implementation tried to rename the index template during\n`init` and did not consider multiple spaces. to fix it, I have:\n* Delete the previous code from `init`\n* Created a new migration that created the new component templates and\nupdated the index templates\n* Deleted the old component template after all spaces migration ran\n* Add support for multiple spaces\n* I also renamed a function inside `init` to make the code more clear\n* Added error handling code that concatenates error messages and logs\nall of them at the end\n\n\n### How to test it:\n\n**Scenario 1**\n\n* The usual way to desk test this PR would be\n* Create a cluster with 8.17\n* Enable the risk Engine in 8.17\n* Create a new space in 8.17\n* Upgrade the cluster to 8.18 (this branch)\n* Enable the risk engine in the second space.\n\n**Scenario 2**\n* Create a cluster with 8.17\n* Enable the risk engine\n* Create a space\n* Enable another risk engine\n* Create another space\n* Upgrade the cluster to 8.18 (this branch)\n* Check if the migration ran in the logs\n* Check if all risk engines are installed and the index templates and\nindex components are there.\n* Install a new risk engine in the space where it isn't installed.\n* Restart Kibana and make sure the migrations didn't run a second time\n\n### Checklist\n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\n[ ] This PR needs to be tested for upgrades between different versions\nand a diverse number of spaces and risk engines installed\n\n---------\n\nCo-authored-by: abhishekbhatia1710 <[email protected]>","sha":"b7908a4c6f91c79459f7b509bfd444ad169d6770","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team: SecuritySolution","Feature:Entity Analytics","Team:Entity Analytics","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[SecuritySolution] Fix risk engine component template renaming","number":212853,"url":"https://github.com/elastic/kibana/pull/212853","mergeCommit":{"message":"[SecuritySolution] Fix risk engine component template renaming (elastic#212853)\n\n## Summary\n\nThe previous implementation tried to rename the index template during\n`init` and did not consider multiple spaces. to fix it, I have:\n* Delete the previous code from `init`\n* Created a new migration that created the new component templates and\nupdated the index templates\n* Deleted the old component template after all spaces migration ran\n* Add support for multiple spaces\n* I also renamed a function inside `init` to make the code more clear\n* Added error handling code that concatenates error messages and logs\nall of them at the end\n\n\n### How to test it:\n\n**Scenario 1**\n\n* The usual way to desk test this PR would be\n* Create a cluster with 8.17\n* Enable the risk Engine in 8.17\n* Create a new space in 8.17\n* Upgrade the cluster to 8.18 (this branch)\n* Enable the risk engine in the second space.\n\n**Scenario 2**\n* Create a cluster with 8.17\n* Enable the risk engine\n* Create a space\n* Enable another risk engine\n* Create another space\n* Upgrade the cluster to 8.18 (this branch)\n* Check if the migration ran in the logs\n* Check if all risk engines are installed and the index templates and\nindex components are there.\n* Install a new risk engine in the space where it isn't installed.\n* Restart Kibana and make sure the migrations didn't run a second time\n\n### Checklist\n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\n[ ] This PR needs to be tested for upgrades between different versions\nand a diverse number of spaces and risk engines installed\n\n---------\n\nCo-authored-by: abhishekbhatia1710 <[email protected]>","sha":"b7908a4c6f91c79459f7b509bfd444ad169d6770"}},"sourceBranch":"8.18","suggestedTargetBranches":["9.0","main","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212853","number":212853,"mergeCommit":{"message":"[SecuritySolution] Fix risk engine component template renaming (elastic#212853)\n\n## Summary\n\nThe previous implementation tried to rename the index template during\n`init` and did not consider multiple spaces. to fix it, I have:\n* Delete the previous code from `init`\n* Created a new migration that created the new component templates and\nupdated the index templates\n* Deleted the old component template after all spaces migration ran\n* Add support for multiple spaces\n* I also renamed a function inside `init` to make the code more clear\n* Added error handling code that concatenates error messages and logs\nall of them at the end\n\n\n### How to test it:\n\n**Scenario 1**\n\n* The usual way to desk test this PR would be\n* Create a cluster with 8.17\n* Enable the risk Engine in 8.17\n* Create a new space in 8.17\n* Upgrade the cluster to 8.18 (this branch)\n* Enable the risk engine in the second space.\n\n**Scenario 2**\n* Create a cluster with 8.17\n* Enable the risk engine\n* Create a space\n* Enable another risk engine\n* Create another space\n* Upgrade the cluster to 8.18 (this branch)\n* Check if the migration ran in the logs\n* Check if all risk engines are installed and the index templates and\nindex components are there.\n* Install a new risk engine in the space where it isn't installed.\n* Restart Kibana and make sure the migrations didn't run a second time\n\n### Checklist\n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\n[ ] This PR needs to be tested for upgrades between different versions\nand a diverse number of spaces and risk engines installed\n\n---------\n\nCo-authored-by: abhishekbhatia1710 <[email protected]>","sha":"b7908a4c6f91c79459f7b509bfd444ad169d6770"}},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
`99.4.0-borealis.0` ⏩ `100.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- First of all, 💯 🎉! > [!Warning] > Please note that the [public changelog for EUI v100.0.0](https://github.com/elastic/eui/releases/tag/v100.0.0) is longer than what's included below. > > Kibana has been using Borealis-specific builds of EUI since November last year (suffixed with `-borealis.X`), which were built from a just-merged EUI feature branch. > Since that feature branch just got merged and released with EUI v100.0.0, **the public changelog differs from what Kibana should be concerned about** due to updating from a custom Borealis-enabled version of EUI. > > You can find the list of all (one 👀) changes made between version `99.4.0-borealis.0` and `100.0.0` below. ## [`v100.0.0`](https://github.com/elastic/eui/releases/v100.0.0) **Bug fixes** - Fixed `EuiComboBox` by cleaning duplicated values when having a delimiter prop. ([elastic#8335](elastic/eui#8335)) Co-authored-by: Elastic Machine <[email protected]>
## Summary As part of Accessibility requirements, a user thats using only the keyboard should be able to know which element they are on at the moment after closing windows. As part of that the 'Ingest Pipelines' page, the 'Manage' button now refocuses once the 'Delete Custom Pipeline' popup is closed. See screenshots below ### Closes elastic#196650 <img width="1437" alt="Screenshot 2025-02-21 at 3 20 47 PM" src="https://github.com/user-attachments/assets/4fa44b18-9856-4e39-9c1b-03dd367d798b" /> <img width="1407" alt="Screenshot 2025-02-21 at 3 19 53 PM" src="https://github.com/user-attachments/assets/71aa01ca-f936-47f2-909e-57f649b03ca5" /> <img width="1443" alt="Screenshot 2025-02-21 at 3 20 05 PM" src="https://github.com/user-attachments/assets/f1df4d64-e4e3-440f-a833-a7b2746def60" /> <img width="1448" alt="Screenshot 2025-02-21 at 3 20 16 PM" src="https://github.com/user-attachments/assets/ac5f4100-b155-417a-b453-5ba9594d06e5" /> Notice that the 'Manage' button is refocused ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Rodney Norris <[email protected]>
…ngest path (elastic#211822) Closes elastic#211783 Part of elastic#195857 ## Summary This PR expands the logic to get the dashboard files based on the agent. We have many different ways to ingest data so we want to add more metrics dashboards to the APM metrics tab. The different ingest paths we have: Classic APM Agent --> APM Server --> ES Vanilla OTel SDKs --> APM Server --> ES EDOT OTel SDKs --> APM Server --> ES Classic APM Agent --> EDOT Collector --> ES Vanilla OTel SDKs. --> EDOT Collector --> ES EDOT OTel SDKs --> EDOT Collector --> ES We agreed on having a dashboard filename pattern to make showing the correct dashboard easier described [here](elastic#195857 (comment)) First, we determine if the ingest path is through APM Server or EDOT Collector by checking the `telemtry.sdk` fields. ## TODOs / Reviewer notes - [ ] Currently, we have a fallback to metrics charts which is valid only if we have APM agent so this PR adds an empty state message: "Runtime metrics are not available for this Agent / SDK type." in case there is no dashboard for the service language. To be improved in elastic#211774 and will be updated in this PR when ready - I will still open it for review as the other logic can be reviewed - The dashboards are to be updated (by the agent team so not part of the changes here) ## Testing: - Using e2e PoC - The available dashboard cases can be found in [loadDashboardFile](https://github.com/jennypavlova/kibana/blob/91f169e19a3fa3f83ca60eb078159c026f9617af/x-pack/solutions/observability/plugins/apm/public/components/app/metrics/static_dashboard/dashboards/dashboard_catalog.ts#L40) - Cases to be checked: - OTel native with Vanilla OTel SDKs with available dashboard (example case file: `otel_native-otel_other-nodejs`, `...-java`, `...-dotnet`) <img width="1903" alt="image" src="https://github.com/user-attachments/assets/44d37b05-a8e7-4f14-a1de-2c631f1843bb" /> - APM server with Vanilla OTel SDKs service with available dashboard (example case file: `classic_apm-otel_other-nodejs`, `...-java`, `...-dotnet`)  - APM server with Classic APM Agent (example case file: `classic_apm-apm-nodejs`, `...-java`) <img width="962" alt="image" src="https://github.com/user-attachments/assets/f9e96dce-55c8-467a-93f0-a09fa219597e" /> - OTel native with Vanilla OTel SDKs without available dashboard (empty state case example: python service)  - APM server with Vanilla OTel SDKs service without available dashboard (empty state) <img width="1910" alt="image" src="https://github.com/user-attachments/assets/5219cf94-5013-4874-aaea-e558cca69281" /> - APM server with Classic APM Agent without available dashboard (Current metrics fallback) <img width="1914" alt="image" src="https://github.com/user-attachments/assets/66342f49-876c-4ad5-a4d1-1414c3abac75" /> -⚠️ OTel native Dashboards are still not available (at the time of adding the description) --------- Co-authored-by: Sergi Romeu <[email protected]> Co-authored-by: Cauê Marcondes <[email protected]> Co-authored-by: kibanamachine <[email protected]>
…tic#213335) ## Summary Fixing misleading info noted in this GH issue ticket elastic/search-team#9483 regarding Elastic managed connectors that are not available in Serverless Connectors empty state page:  Connectors list page (without the Callout banner on top):  ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
…aly Explorer (elastic#213245) Fix for: elastic#211017 We were using legacy theme which introduced some margins to the chart. However, the issue is visible from `69.1.0` (introduced in Kibana `9.0`) version of `@elastic/charts` as they have fixed heatmap margins and paddings - elastic/elastic-charts#2577. After the fix:  
…lastic#212982) ## Summary Background: elastic#212173 Based off of feedback on the work in the PRs listed in that issue, additional performance improvements can be made to the cells rendered in the alert table. The changes made in this PR involve migrating out shared context to a provider so certain hooks (some expensive... i.e. browserFieldsByName) aren't made for every cell in the UI, but once and passed down to each cell accordingly. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary Closes elastic#207024 Closes elastic#207022 Increased retries since the bump agent policies were made async and takes longer than before.
…tion (elastic#213355) ## Summary Fixes the bug described here elastic#192255 (comment) <img width="1094" alt="image" src="https://github.com/user-attachments/assets/69d4f004-6a66-416b-8aa6-e477b0380010" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…lastic#212807) ## Summary Adds to the Dev Docs Debugging tutorial suggested configurations for VS Code users for debugging Kibana server code, Jest unit tests, and functional tests. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
…g to productFeatureKeys (elastic#213105) ## Summary Fixes: elastic#212667 AI Assistant management is registered according to `productFeatureKeys` set by security_solution_ess or security_solution_serverless plugin. To verify: - Security project ``` yarn es serverless --projectType security --kill --clean -E —ssl xpack.security.authc.api_key.enabled=true yarn serverless-security --no-base-path ``` Update xpack.securitySolutionServerless.productTypes in config/serverless.security.yml to switch between `essentials` and `complete` tier Project essentials: <img width="2140" alt="Screenshot 2025-03-04 at 17 05 59" src="https://github.com/user-attachments/assets/c2df5d20-a0f8-4ee4-82d3-b04a47a47f53" /> Project complete: <img width="2199" alt="Screenshot 2025-03-04 at 17 07 16" src="https://github.com/user-attachments/assets/0e6f0c5d-f318-4db8-925b-01e46ed76a7b" /> - ESS License trial and enterprise: ``` yarn es snapshot --license trial -E xpack.security.authc.api_key.enabled=true -E discovery.type=single-node -E network.host=0.0.0.0 ``` https://github.com/user-attachments/assets/1771f51b-7b48-46e5-8bf6-3918c6e913c5 License basic and others: ``` yarn es snapshot --license basic -E xpack.security.authc.api_key.enabled=true -E discovery.type=single-node -E network.host=0.0.0.0 ``` https://github.com/user-attachments/assets/fe00454c-10f6-4862-8eca-03179431ea6c --------- Co-authored-by: Sergi Massaneda <[email protected]> Co-authored-by: kibanamachine <[email protected]>
…12509) **Resolves: elastic/security-team#11502 (internal) This PR implements following changes and adds API integration tests for them: - [x] Users with any license can export prebuilt rules (with enabled feature flag) - [x] Users with Basic/Essentials license can import prebuilt rules only if they are non-customized and the feature flag is enabled - [x] Users with Enterprise/Complete license can import prebuilt rules without restrictions Flaky test runner (had to create 4 separate runs to test all configs): - [1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7987) - [2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7986) - [3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7988) - [4](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7989)
Fix external links that incorrectly use `.md` instead of `.html`.
## Summary In an effort to make SLI charts more quickly visible on the SLO overview page, remove SLO details that do not give users valuable insight into key metrics and add them to a new tab. Retain some of the SLO details above the tabs like SLI value, tags, and description (see figma for the inspiration) https://www.figma.com/design/91R0OtRZHy5xvaE8dGStBo/SLO%2FSLI-assets?node-id=4601-59103&t=K1vI6qtXbb48XPgr-1 <img width="1474" alt="Screenshot 2025-02-28 at 4 53 05 PM" src="https://github.com/user-attachments/assets/3fdbe766-4047-45b5-a986-3a029c09bd1f" />  ## Release Notes SLO overview should give users a clear, immediate picture into key objective data. Previously, the user would have had to scroll past static data that describes the SLO definition before seeing valuable information about their SLIs. This static data has been moved to a separate tab, making charts more easily accessible. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
This PR adds pendingRecoveredCount field to AAD as a step to make ADD source of truth. In the next step we can build alerts in the alerting task runner from AAD rather than task state.
Since we decided we don't want to provide routing for classic streams, it doesn't make sense to be on the level of the ingest stream in the API. This PR moves routing next to fields to make clear that it's only supported for wired streams.
…omized calculation (elastic#213250) **Partially addresses: elastic#210358 ## Summary ### Editing of prebuilt rules with missing base versions **When the base version** of a currently installed prebuilt rule **is missing** among the `security-rule` asset saved objects, and the user edits this rule: - We should mark the rule as customized, only if the new rule settings are different from the current rule settings. - For example, adding a new tag should mark the rule as customized. Then, if the user removes this tag, the rule should remain to be marked as customized. This matches the current behavior. - However, if the user saves the rule without making any changes to it, it should keep its `is_customized` field as is. This is different from the current behavior. ### Importing of prebuilt rules with missing base versions **When the base version** of a prebuilt rule that is being imported **is missing** among the `security-rule` asset saved objects, and the user imports this rule: - If this rule is not installed, it should be created with `is_customized` field set to `false`. - If this rule is already installed, it should be updated. - Its `is_customized` field should be set to `true` if the rule from the import payload is not equal to the installed rule. - Its `is_customized` field should be be kept unchanged (`false` or `true`) if the rule from the import payload is equal to the installed rule.
…s, along with arbitrary headers (elastic#213117)
## Summary Relates elastic/ingest-dev#4720 This PR adds retry logic to the task that handles automatic agent upgrades originally implemented in elastic#211019. Complementary fleet-server change which sets the agent's `upgrade_attempts` to `null` once the upgrade is complete.: elastic/fleet-server#4528 ### Approach - A new `upgrade_attempts` property is added to agents and stored in the agent doc (ES mapping update in elastic/elasticsearch#123256). - When a bulk upgrade action is sent from the automatic upgrade task, it pushes the timestamp of the upgrade to the affected agents' `upgrade_attempts`. - The default retry delays are `['30m', '1h', '2h', '4h', '8h', '16h', '24h']` and can be overridden with the new `xpack.fleet.autoUpgrades.retryDelays` setting. - On every run, the automatic upgrade task will first process retries and then query more agents if necessary (cf. elastic/ingest-dev#4720 (comment)). - Once an agent has completed and failed the max retries defined by the retry delays array, it is no longer retried. ### Testing The ES query for fetching agents with existing `upgrade_attempts` needs the updated mappings, so it might be necessary to pull the latest `main` in the `elasticsearch` repo and run `yarn es source` instead of `yarn es snapshot` (requires an up-to-date Java environment, currently 23). In order to test that `upgrade_attempts` is set to `null` when the upgrade is complete, fleet-server should be run in dev using the change in elastic/fleet-server#4528. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Low probability risk of incorrectly triggering agent upgrades. This feature is currently behind the `enableAutomaticAgentUpgrades` feature flag. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Julia Bardi <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Closes elastic#209122. ### 🎥 Demo https://github.com/user-attachments/assets/34d8b544-3ff6-4332-8856-57014fb1fc8a ### How to test? 1. Ingest some data using `logs_and_metrics` synthtrace scenario 2. Go to `/app/observability/overview` or `app/metrics/hosts` 3. Click `logs` link 4. You should be redirected to discover and `All logs` should be set by default --------- Co-authored-by: kibanamachine <[email protected]>
…`InternalStateStore` (elastic#208784) ## Summary This PR replaces Discover's current `DiscoverInternalStateContainer` (based on Kibana's custom `ReduxLikeStateContainer`) with an actual Redux store using Redux Toolkit. It's the first step toward migrating all of Discover's state management to Redux as part of the Discover tabs project. Part of elastic#210160. Resolves elastic#213304. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
…imeline (elastic#211343) resolves elastic#198944 ## Summary Currently, the redux store can become out of sync with the state in the UI, leading to the selected dataview not being preserved in the store, and thereby not being saved when the timeline is saved. This PR sets the selected dataview and patterns at the point of saving to ensure that they are set and not overriden. For additional background, see referenced issues.
## Summary It closes elastic#210714 This PR adds the Initializing screen shown during the initialization step of the Asset Inventory onboarding. ## Recording https://github.com/user-attachments/assets/01631884-60bb-417c-9f36-3b37ca8de4a4
…#213075) Fix for: elastic#212569 From what I found, the issue was with the `useUrlStateService` after changes introduced in elastic#203224, which made the service more generic. When filtering causes the `explorer` to remount the `AnomaliesTable`, pagination state updates are triggered before the effect that sets `setCallback.current` executes. Initializing the ref with `setState` ensures its availability from the first render. https://github.com/user-attachments/assets/d1aa8409-56e5-4632-a5f2-82350b877db6
davismcphee
force-pushed
the
discover-state-refactor
branch
from
14becb8 to
714c6a0
Compare
|
Closing, PR against main here: elastic#213501. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIP.
Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.