Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dinit: show in --version if dinit was compiled with initgroups #213

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

mobin-2008
Copy link
Collaborator

I think it's useful to allow checking it via dinit -v

Signed-off-by: Mobin "Hojjat" Aydinfar <[email protected]>

@mobin-2008 mobin-2008 added Enhancement/New Feature Improving things or introduce new feature A-Importance: Low Issues such as harmless typos are included in this category. C-dinit Things about the main parts of dinit labels Aug 11, 2023
@mobin-2008 mobin-2008 requested a review from davmac314 August 11, 2023 10:20
Copy link
Owner

@davmac314 davmac314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's useful to allow checking it via dinit -v

I disagree.

"intgroups" is just a function. It is not a feature. It will mean nothing to most users. If you want to list a feature based on USE_INITGROUPS being set, use an appropriate name for the feature.

The USE_INITGROUPS build option actually gates the use of two non-POSIX functions: initgroups and setgroups. But the feature that these implement support for is supplemental groups. (We should, really, rename USE_INITGROUPS to something more appropriate.)

The commit message is wrong, there is no -v option. It should be --version.

@davmac314
Copy link
Owner

If you can change the feature name to something suitable - maybe "supplemental-groups" - I'd like to get this for 0.17. We are almost there!

@davmac314 davmac314 changed the title dinit: show in -v that if dinit was compiled with initgroups dinit: show in --version if dinit was compiled with initgroups Aug 13, 2023
@davmac314 davmac314 merged commit 9b41183 into davmac314:master Aug 13, 2023
@mobin-2008 mobin-2008 deleted the show_initgrps branch August 14, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Importance: Low Issues such as harmless typos are included in this category. C-dinit Things about the main parts of dinit Enhancement/New Feature Improving things or introduce new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants