Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to service dir as working directory for services #244

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

q66
Copy link
Contributor

@q66 q66 commented Sep 12, 2023

@davmac314 any idea about the failing integration tests? i'm not quite seeing it

@q66 q66 force-pushed the wrksrc-service-dir branch from e85db9f to 283795e Compare September 12, 2023 23:13
@q66
Copy link
Contributor Author

q66 commented Sep 12, 2023

ps-environ was a forgotten thing on my side, the CI log has shown that... the other one is still failing

@q66 q66 force-pushed the wrksrc-service-dir branch from 283795e to dcc14ea Compare September 12, 2023 23:24
@q66
Copy link
Contributor Author

q66 commented Sep 12, 2023

looks like the issue was $DINITCTL not being absolute, so i wrapped it in realpath

@q66 q66 force-pushed the wrksrc-service-dir branch 2 times, most recently from 9dc50a5 to 65fa30e Compare September 12, 2023 23:30
@q66 q66 force-pushed the wrksrc-service-dir branch from 65fa30e to 2404786 Compare September 12, 2023 23:55
@q66
Copy link
Contributor Author

q66 commented Sep 12, 2023

looks like macos does not have realpath, i just worked around the issue by cd'ing back from the script...

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
8.1% 8.1% Duplication

@davmac314 davmac314 merged commit b74c526 into davmac314:master Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants