-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coercion for embedded shallow attributes type, receiving unexpected parameters #34
Open
javierseixas
wants to merge
6
commits into
davydovanton:master
Choose a base branch
from
LemontechSA:fix-nested-shallow-attributes-with-unexpected-parameters
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierseixas
commented
Nov 15, 2019
# @private | ||
# | ||
# @since 0.9.4 | ||
class Boolean; end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to define Boolean
class for adding to the DEFAULT_TYPE_OBJECTS
.
javierseixas
changed the title
Adds test for embedded shallow attributes with unexpected parameters
Fix coercion for embedded shallow attributes type, receiving unexpected parameters
Nov 15, 2019
Options in attributes
javierseixas
force-pushed
the
fix-nested-shallow-attributes-with-unexpected-parameters
branch
from
August 14, 2020 02:48
c4c8b43
to
80990d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROBLEM
Having two classes related like follow:
... when the embedded class receives parameters that doesn't match the defined attributes:
... an error raises because doesn't find the definition in the class.
When a class including
ShallowAttribues
is initialized, during the initialization parameters non matching attributes are dismissed. But it doesn't happen during the lower levels in the hierarchy, because the objects are creating according to the type.SOLUTION
Adding some logic during the
type
coercion and initialization avoid the conflict.