Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker file #10

Closed
wants to merge 1 commit into from
Closed

Docker file #10

wants to merge 1 commit into from

Conversation

agentcobra
Copy link

Hi everybody,
I'm a docker beginner,
I'm trying to dockerize blockshell

@agentcobra
Copy link
Author

#8 maybe need for my docker container :)

@smitthakkar96
Copy link

Why will someone containerize block shell since as far as I know it is only meant for learning blockchain

@agentcobra
Copy link
Author

it's easier to install and less problem with python 2.7

@smitthakkar96
Copy link

Well in that case submit a PR that makes it python 3 compatible and upload a RPM spec to package it for fedora, do debian packaging and also homebrew. You containerize things to run it in prodution on servers this is a CLI. FYI docker is not a package manager.

@agentcobra agentcobra closed this Feb 1, 2018
@seeder
Copy link

seeder commented Feb 7, 2018

docker ain't complicated, checkout #13

@agentcobra
Copy link
Author

agentcobra commented Feb 9, 2018

thx @seeder, I've merge it.
you can close your PR #13 because @smitthakkar96 will not approve it, see above

@daxeel
Copy link
Owner

daxeel commented Feb 10, 2018

@seeder @agentcobra It's great that you guys are putting efforts into this very young project in Blockchain field. Our next plan is to make Blockshell decentralized and then we will make it Docker compatible. So, guys, I know docker will add beauty to this project but before that, we need to add decentralization. If you can work on decentralization, then it would be super awesome thing. Hope you guys are getting me.

@seeder
Copy link

seeder commented Feb 22, 2018

I think you are mistaking some domains here @daxeel
Your project is already docker compatible.
Docker image is a great way to package CLI, daemons and even readme files.

I have just shared something what is dirt easy for me, as I work with docker on daily basis and I have noticed you don't.

I am happy to just leave my fork/pr for everyone who wants to just use it inside Docker. @agentcobra enjoy!

Cheerio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants