Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: preset targets #10

Merged
merged 1 commit into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

</div>


<h1 align="center">Daytona AWS Provider</h1>
<div align="center">
This repository is the home of the <a href="https://github.com/daytonaio/daytona">Daytona</a> AWS Provider.
Expand All @@ -24,28 +23,27 @@ This repository is the home of the <a href="https://github.com/daytonaio/daytona
<a href="https://x.com/Daytonaio">X</a>
</p>


The AWS Provider allows Daytona to create and manage workspace projects on Amazon EC2 instances.

To use this provider, ensure your AWS programmatic access user has the `AmazonEC2FullAccess` permissions.
This policy grants the necessary permissions to manage EC2 instances, which is crucial for Daytona's workspace project creation and management.

## Target Options

| Property | Type | Optional | DefaultValue | InputMasked | DisabledPredicate |
|---------------------------------|---------------|-------------|-------------------------------|-----------------------|---------------------|
| Region | String | true | us-east-1 | false | |
| Image Id | String | true | ami-04a81a99f5ec58529 | false | |
| Instance Type | String | true | t2.micro | false | |
| Device Name | String | true | t2./dev/sda1 | false | |
| Volume Size | String | true | 10 | false | |
| Volume Type | String | true | gp3 | false | |
| Access Key Id | String | false | | true | |
| Secret Access Key | String | false | | true | |
| Property | Type | Optional | DefaultValue | InputMasked | DisabledPredicate |
| ----------------- | ------ | -------- | --------------------- | ----------- | ----------------- |
| Region | String | true | us-east-1 | false | |
| Image Id | String | true | ami-04a81a99f5ec58529 | false | |
| Instance Type | String | true | t2.micro | false | |
| Device Name | String | true | t2./dev/sda1 | false | |
| Volume Size | String | true | 10 | false | |
| Volume Type | String | true | gp3 | false | |
| Access Key Id | String | false | | true | |
| Secret Access Key | String | false | | true | |

### Default Targets
### Preset Targets

The AWS Provider has no default targets. Before using the provider you must set the target using the `daytona target set` command.
The AWS Provider has no preset targets. Before using the provider you must set the target using the `daytona target set` command.

## Code of Conduct

Expand All @@ -66,4 +64,3 @@ Afterwards, navigate to the [contributing guide](CONTRIBUTING.md) to get started

For more information on how to use and develop Daytona, talk to us on
[Slack](https://go.daytona.io/slack).

2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ replace github.com/docker/go-connections => github.com/docker/go-connections v0.

require (
github.com/aws/aws-sdk-go v1.54.19
github.com/daytonaio/daytona v0.38.0
github.com/daytonaio/daytona v0.40.0
github.com/docker/docker v27.2.0+incompatible
github.com/google/uuid v1.6.0
github.com/hashicorp/go-hclog v1.6.3
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -725,8 +725,8 @@ github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/davidmz/go-pageant v1.0.2 h1:bPblRCh5jGU+Uptpz6LgMZGD5hJoOt7otgT454WvHn0=
github.com/davidmz/go-pageant v1.0.2/go.mod h1:P2EDDnMqIwG5Rrp05dTRITj9z2zpGcD9efWSkTNKLIE=
github.com/daytonaio/daytona v0.38.0 h1:T5EkDP8jf6GRPVHIExmfFLnNVunyjgobtcze4bdjmV8=
github.com/daytonaio/daytona v0.38.0/go.mod h1:ZZ+sA66/4715zoWUbtpjNb2VfueJ8uHxCZAayUhDzAw=
github.com/daytonaio/daytona v0.40.0 h1:+EUCUbKXJSP+QJOGglz38J8/Q9vtuItJb6YZx8Uv0p8=
github.com/daytonaio/daytona v0.40.0/go.mod h1:ZZ+sA66/4715zoWUbtpjNb2VfueJ8uHxCZAayUhDzAw=
github.com/dblohm7/wingoes v0.0.0-20240123200102-b75a8a7d7eb0 h1:vrC07UZcgPzu/OjWsmQKMGg3LoPSz9jh/pQXIrHjUj4=
github.com/dblohm7/wingoes v0.0.0-20240123200102-b75a8a7d7eb0/go.mod h1:Nx87SkVqTKd8UtT+xu7sM/l+LgXs6c0aHrlKusR+2EQ=
github.com/digitalocean/go-smbios v0.0.0-20180907143718-390a4f403a8e h1:vUmf0yezR0y7jJ5pceLHthLaYf4bA5T14B6q39S4q2Q=
Expand Down
2 changes: 1 addition & 1 deletion pkg/provider/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func (a *AWSProvider) GetTargetManifest() (*provider.ProviderTargetManifest, err
return types.GetTargetManifest(), nil
}

func (a *AWSProvider) GetDefaultTargets() (*[]provider.ProviderTarget, error) {
func (a *AWSProvider) GetPresetTargets() (*[]provider.ProviderTarget, error) {
return new([]provider.ProviderTarget), nil
}

Expand Down
Loading