Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private container registries support #3

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

bcmmbaga
Copy link
Collaborator

@bcmmbaga bcmmbaga commented Jun 6, 2024

Add Private Container Registries Support

Description

This merge request enhances the provider by adding support for Docker images sourced from private container registries. The new functionality allows images to be pulled locally from a private registry, tagged appropriately, and then pushed to the Fly.io registry for deployment.

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Related Issue(s)

@bcmmbaga bcmmbaga requested a review from Tpuljak June 6, 2024 21:47
pkg/provider/util/fly.go Outdated Show resolved Hide resolved
pkg/provider/util/fly.go Outdated Show resolved Hide resolved
@bcmmbaga bcmmbaga force-pushed the support-private-image-registry branch from a99fb16 to 48868e5 Compare June 10, 2024 19:03
@bcmmbaga bcmmbaga requested a review from Tpuljak June 11, 2024 20:31
pkg/provider/util/fly.go Outdated Show resolved Hide resolved
pkg/provider/util/fly.go Outdated Show resolved Hide resolved
@bcmmbaga bcmmbaga force-pushed the support-private-image-registry branch 3 times, most recently from 4d32ebc to e35081d Compare June 15, 2024 20:36
pkg/provider/util/fly.go Outdated Show resolved Hide resolved
@bcmmbaga bcmmbaga force-pushed the support-private-image-registry branch 2 times, most recently from 60b27de to aab7542 Compare June 18, 2024 17:26
@bcmmbaga bcmmbaga force-pushed the support-private-image-registry branch from aab7542 to 49b0bb3 Compare June 19, 2024 08:28
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcmmbaga nice work on this PR!

@Tpuljak Tpuljak merged commit 751f646 into main Jun 25, 2024
3 checks passed
@Tpuljak Tpuljak deleted the support-private-image-registry branch June 25, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants