Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server startup sequence to wait for all components #1371

Closed
wants to merge 1 commit into from

Conversation

Ximax80
Copy link

@Ximax80 Ximax80 commented Nov 26, 2024

This PR addresses issue #1357 by ensuring that the Daytona server command waits for all components (API server, providers, local registry, and headscale server) to start successfully before exiting. It implements a retry mechanism and provides detailed logging for better visibility into the startup process.

@Ximax80 Ximax80 requested a review from a team as a code owner November 26, 2024 04:53
@Ximax80
Copy link
Author

Ximax80 commented Nov 26, 2024

@quest-bot loot #1357

Copy link

quest-bot bot commented Nov 26, 2024

Quest PR submitted! image Quest PR submitted!

@Ximax80, you are attempting to solve the issue and loot this Quest. Will you be successful?


Questions? Check out the docs.

@mojafa
Copy link
Collaborator

mojafa commented Nov 26, 2024

@Ximax80 please sign off on your commit as the DCO check fails.

@mojafa
Copy link
Collaborator

mojafa commented Nov 26, 2024

  • For a Single Commit:
    Amend your last commit to include the sign-off:
 git commit --amend --signoff then git push --force
  • Adding a Sign-Off to an Existing Commit:
Amend the Last Commit: git commit --amend --signoff then git push --force
  • Automating Sign-Offs for Future Commits
To ensure all future commits are signed off automatically, you can create a Git alias or configure a commit template.
Create a Git Alias: git config --global alias.commit "commit -s” or Use a Commit Template echo "Signed-off-by: Your Name <[email protected]>" > ~/.gitmessage.txt then configure Git to use the template: git config --global commit.template ~/.gitmessage.txt





@Ximax80 Ximax80 force-pushed the fix-server-startup-sequence branch from 56d2180 to 0baf021 Compare November 26, 2024 14:43
@Tpuljak
Copy link
Member

Tpuljak commented Nov 29, 2024

#1390 (comment)

@Tpuljak Tpuljak closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants