Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Option to Specify Other LLM Providers in .env #43

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

RS-labhub
Copy link

Formatted .env a bit also.

/closes #10

/claim #10

@RS-labhub
Copy link
Author

@nkkko could you review this pr?

@mojafa
Copy link
Contributor

mojafa commented Dec 6, 2024

@RS-labhub on it

@mojafa
Copy link
Contributor

mojafa commented Dec 7, 2024

@RS-labhub I'm getting this error:
Screenshot 2024-12-08 at 00 53 59

@RS-labhub
Copy link
Author

@RS-labhub I'm getting this error: Screenshot 2024-12-08 at 00 53 59

Did you install fasthtml?? pip install fasthtml

By the way, I didn't touched the previous packages. So, it must be not from my side!

@mojafa
Copy link
Contributor

mojafa commented Dec 11, 2024

@RS-labhub I’ve updated main with some changes that affect this PR. Could you please rebase your branch onto the latest main and resolve any conflicts that come up? Once that’s done, we can review the updated changes and move forward.

@RS-labhub
Copy link
Author

All good this side!

@mojafa
Copy link
Contributor

mojafa commented Dec 12, 2024

@RS-labhub your pr doesn't have latest chnages, please rebase.
Screenshot 2024-12-13 at 00 30 07

@RS-labhub
Copy link
Author

Check it now @mojafa

@mojafa
Copy link
Contributor

mojafa commented Dec 17, 2024

@RS-labhub I was able to generate a devcoonatiner witghout specifiying LLM PROVIDER.

Screenshot 2024-12-17 at 23 46 56

I commendtyed out the bit for # LLM_PROVIDER=AzureOpenAI and used my old ENV and it worked. I was expecting an error to tell me ot specify my LLM

@mojafa
Copy link
Contributor

mojafa commented Dec 17, 2024

Screenshot 2024-12-17 at 23 48 29

@RS-labhub
Copy link
Author

RS-labhub commented Dec 18, 2024

I commendtyed out the bit for # LLM_PROVIDER=AzureOpenAI and used my old ENV and it worked. I was expecting an error to tell me ot specify my LLM

The issue here is that the script defaults to AzureOpenAI if the LLM_PROVIDER is not specified in the env, so it bypasses the missing environment variables check even when LLM_PROVIDER is absent.

@mojafa
Copy link
Contributor

mojafa commented Dec 18, 2024

@RS-labhub i'm seeing the Error: LLM_PROVIDER is not specified. Please set LLM_PROVIDER in your environment variables in the termnial but code still runs and geenrates devconatiner.

Screenshot 2024-12-18 at 21 26 25 Screenshot 2024-12-18 at 21 27 44

@mojafa
Copy link
Contributor

mojafa commented Dec 18, 2024

Oh i found if i changed the repo to a new one, it worked.

Screenshot 2024-12-18 at 21 30 07 Screenshot 2024-12-18 at 21 30 00

@mojafa
Copy link
Contributor

mojafa commented Dec 18, 2024

Screenshot 2024-12-18 at 21 41 35 I swtiched from azure to Anthropic. added my key and it doesnt run

@mojafa
Copy link
Contributor

mojafa commented Dec 19, 2024

@RS-labhub pr fails DCO check, please sognoff your commits

@mojafa
Copy link
Contributor

mojafa commented Dec 19, 2024

@RS-labhub getting this error on runnninh pip install. I dont think we have that distibition for antrohpic, please test on your end. no rush
Screenshot 2024-12-19 at 16 30 20

@RS-labhub
Copy link
Author

Done
image

Signed-off-by: Rohan Sharma <[email protected]>
@mojafa
Copy link
Contributor

mojafa commented Dec 20, 2024

fix DCO please sign your commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Option to Specify Other LLM Providers in .env
2 participants