Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set db-operator version on database CR during full reconcile #50

Merged
merged 5 commits into from
May 8, 2024

Conversation

robertbublik
Copy link

I had to add a namespace environment variable to allow db-operator to retrieve the namespace in which it runs in. Other than that I simply added a new field version to the Database CR.

@robertbublik robertbublik force-pushed the 79-add-version branch 2 times, most recently from 982e015 to 4ac48bd Compare April 21, 2024 13:07
Copy link
Member

@allanger allanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing

@allanger
Copy link
Member

But also, CI has failed, so it would be nice to check what's wrong

@robertbublik
Copy link
Author

But also, CI has failed, so it would be nice to check what's wrong

Well, it looks like it's working as expected. 😅

2024-04-25T18:41:01Z ERROR an error occurred during the reconciliation {"controller": "database", "controllerGroup": "kinda.rocks", "controllerKind": "Database", "Database": {"name":"db-operator-mysql","namespace":"db-operator-whz3ob85lz"}, "namespace": "db-operator-whz3ob85lz", "name": "db-operator-mysql", "reconcileID": "5f2862b2-729f-4b6f-805b-994981395cad", "error": "Database.kinda.rocks "db-operator-mysql" is invalid: operatorVersion: Required value"}

Can I somehow insert another image to the CI?

@allanger
Copy link
Member

Ah, sure, we need to release the db-operator versions first, sorry

@allanger
Copy link
Member

@bobertrublik
I guess we should add a note to the notes.txt, because it's kind of breaking for ones who don't install CRDs with the chart. Also, I would update the README. Could you please add the migration plan to both of them?

@robertbublik
Copy link
Author

Hey, I added a migration plan to the README but I don't fully understand how the NOTES.txt works. At the top there is the following text

Breaking changes and migration paths:

{{ .Chart.Version }} is not breaking, you don't have to worry

but how does it know which version is breaking and which is not? 😅

@allanger
Copy link
Member

allanger commented May 1, 2024

but how does it know which version is breaking and which is not? 😅

Just replace

{{ .Chart.Version }} is not breaking, you don't have to worry

with something like

{{ .Chart.Version }} is not breaking if CRDs are managed by helm, otherwise please read

... Migration plan ...

@robertbublik
Copy link
Author

I hope this looks fine for you. 🙂

@allanger allanger merged commit 98aa410 into db-operator:main May 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants