-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cards to match with dbux-3 #193
Conversation
🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/refactor-guidelines-3-card |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as the cards contents have been removed, we need to transfer those to the demonstration styles and markup to fix the homepage again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally we should encourage to use list markup instead of simple div
tags in case that the contents are actually a list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tests report problems with the color contrast for information colors, compare to e.g. https://colourcontrast.cc/0087b9/ffffff
Do we need this? |
For the moment I could think about keeping a beautiful homepage as an entrèe. And we could even also "remove" the defaults contents in general for the moment even though that I would bet that we'll add them a little later again because these contents are such a generic use case. |
Do you talk about the .hbs file?
|
Yeah I know, one of some of the JavaScript frameworks frontend rendering downsides … ;-) |
this has been reported in the meanwhile and will get looked into in parallel. |
…/core into refactor-guidelines-3-card
elsewhere we get an exploded result in case of filesize
No description provided.