Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cards to match with dbux-3 #193

Merged
merged 26 commits into from
Nov 23, 2022
Merged

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Nov 22, 2022

No description provided.

@github-actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/refactor-guidelines-3-card

Copy link
Member

@mfranzke mfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the cards contents have been removed, we need to transfer those to the demonstration styles and markup to fix the homepage again.

Copy link
Member

@mfranzke mfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally we should encourage to use list markup instead of simple div tags in case that the contents are actually a list.

Copy link
Member

@mfranzke mfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests report problems with the color contrast for information colors, compare to e.g. https://colourcontrast.cc/0087b9/ffffff

@nmerget
Copy link
Member Author

nmerget commented Nov 23, 2022

as the cards contents have been removed, we need to transfer those to the demonstration styles and markup to fix the homepage again.

Do we need this?
Because we will move the documentation and we use this branch just for testing the scss in components

@mfranzke
Copy link
Member

mfranzke commented Nov 23, 2022

as the cards contents have been removed, we need to transfer those to the demonstration styles and markup to fix the homepage again.

Do we need this? Because we will move the documentation and we use this branch just for testing the scss in components

For the moment I could think about keeping a beautiful homepage as an entrèe. And we could even also "remove" the defaults contents in general for the moment even though that I would bet that we'll add them a little later again because these contents are such a generic use case.

@nmerget
Copy link
Member Author

nmerget commented Nov 23, 2022

Additionally we should encourage to use list markup instead of simple div tags in case that the contents are actually a list.

Do you talk about the .hbs file?
I think a card is an own component, we would wrap it inside of a div later in mitosis. So at the end we would have something like:

  • ...

@mfranzke
Copy link
Member

mfranzke commented Nov 23, 2022

Additionally we should encourage to use list markup instead of simple div tags in case that the contents are actually a list.

Do you talk about the .hbs file? I think a card is an own component, we would wrap it inside of a div later in mitosis. So at the end we would have something like:

  • ...

Yeah I know, one of some of the JavaScript frameworks frontend rendering downsides … ;-)
We'll still have regular HTML output that could be pure and without the additional div / HTML tag overhead/waste.

@mfranzke
Copy link
Member

mfranzke commented Nov 23, 2022

the tests report problems with the color contrast for information colors, compare to e.g. https://colourcontrast.cc/0087b9/ffffff

this has been reported in the meanwhile and will get looked into in parallel.

@mfranzke mfranzke enabled auto-merge (squash) November 23, 2022 08:09
@mfranzke mfranzke disabled auto-merge November 23, 2022 08:10
@mfranzke mfranzke enabled auto-merge (squash) November 23, 2022 08:27
@mfranzke mfranzke self-requested a review November 23, 2022 09:57
@mfranzke mfranzke merged commit cfc544c into dbux-3 Nov 23, 2022
@mfranzke mfranzke deleted the refactor-guidelines-3-card branch November 23, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants