Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with selenium-webdriver 4.x #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nevans
Copy link

@nevans nevans commented Jan 24, 2022

Updated to tests for all maintained ruby versions, and test against the latest versions of all relevant gems.

It would be better to:

  • either drop all support for selenium-webdriver 3.x, simplifying the code a little bit
  • or explicitly add selenium-webdriver 3.x to the testing matrix.

I'd personally vote to just drop support for the older selenium. If a project doesn't want to upgrade selenium yet, they can also just use the older version of capybara-chromedriver-logger, right? 🙂

Also, it looks like the travis-ci builds aren't running. Probably it can be fixed by simply logging into travis-ci.com. Or perhaps updating to github actions is worthwhile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant