fix code for warm reboot to work with FW controlled ports #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
fix the code to work also after warm reboot
to work with FW controlled ports
in warm reboot the control state sysfs of each port does not change unlike reboot or fast boot
Work item tracking
How I did it
check procfs cmdline if warm reboot done
this is due to the fact pmon dont recognize warm reboot when it's taking place since pmon is loaded after warm reboot is finished
if warm reboot done - check in static detection part for each port if it's FW controlled. if so - leave it this way and stop the state machine flow (set it to final state).
How to verify it
boot a switch with CMIS host management with at least one FW controlled port (non active cables or non cmis cables)
then run warm reboot
verify no errors of sysfs reading appears for control sysfs
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)