Submission fix #543
Merged
Submission fix #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preranaandure
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem with new WLA and AUA proposals not being accepted on the basis of vessel registration number already been in use when they actually were not.
Investigation revealed that the blocking approvals check included approvals with proposals where the vessel ownership fields were set to None. Because new proposals also have vessel ownership fields set to None, effectively any approved proposal with no vessel ownership would render all application unable to be submitted.
This would not usually be a problem as all approved proposals should have vessel ownership set, however an exception to this has occurred on UAT. This PR fixes the validation query to only retrieve approved proposals with vessel ownerships set (using the rego_no otherwise) to allow submissions even after the unexpected behaviour has occurred.
Further work to determine how an accepted proposal exists without a vessel ownership can happen and what, if any, further impact it may have.
Some general validation fixes RE vessel dimensions have also been included.