Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test, and hopefully fix, incremental composite keys #144

Merged
merged 11 commits into from
Jun 11, 2023

Conversation

lpezet
Copy link
Contributor

@lpezet lpezet commented Apr 2, 2023

resolves #143

Description

Setup to test, and then fix, the macro incremental_delete when an array is used with unique_key in model configuration.

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md with information about my change

@dbeatty10
Copy link
Owner

Nice work on this @lpezet -- I'm planning on reviewing this along with #146 next week.

Copy link
Owner

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this and fixing it @lpezet 🤩

@moszutij and @wesen added both of you to the list of contributors for your recent contributions to #144 and #146 🏆

@dbeatty10 dbeatty10 merged commit c3e6076 into dbeatty10:main Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in macro incremental_delete when using composite keys for unique_key
2 participants